Mimir query engine: sync upstream test cases #8911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/sync-mqe-tests
branch
from
8bb8d4f to
8fa615d
Compare
charleskorn
force-pushed
the
charleskorn/sync-mqe-tests
branch
from
8fa615d to
a840fdb
Compare
jhesketh
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR syncs the upstream test cases in
pkg/streamingpromql/testdata/upstreamwith those from Prometheus, and adds a test to enforce that they remain in sync in the future.Many of the test cases had minor whitespace differences which I've corrected.
Most of the new test cases are for features that are currently not supported by MQE.
There is one new test case in
aggregators.test(source) that currently fails. This test was introduced as part of prometheus/prometheus#14074, and we'll have to implement something similar to what that PR does. I've left this for a follow-up PR, however.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.