Tool for doing gap analysis of TSDB blocks #8453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add some docs and a description to the PR? Other tools have a docs file in |
There was a problem hiding this comment.
overall looks good. I'd use PostingsForMatchers and break up analyzeBlockForGaps into multiple functions. I guess we can go around infinitely cleaning this up, but breaking it up should make it easier for someone to dive in two years from today and make a meaningful change without too much hassle.
tools/tsdb-gaps/main.go
Outdated
| End: timestamps[i+1], | ||
| Intervals: int(missedSamples), | ||
| }) | ||
| seriesStats.MissedSamples += uint64(missedSamples) |
There was a problem hiding this comment.
should we increment missed samples for the series even if the gap itself is uninteresting? Otherwise MissedSamples is just a sum of all the reported missed samples in all gaps
dimitarvdimitrov
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This tool analyzes TSDB blocks for gaps in series data. The README has a good description with the syntax and examples. The purpose is to process every sample for a given set of series in a block and check for missing samples based on flexible filters.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.