Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimir query engine: add support for basic trigonometric and mathematical functions #8430

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Jun 20, 2024

What this PR does

This PR adds support for a number of basic trigonometric and mathematical functions to the Mimir query engine:

  • abs
  • acosh
  • asin
  • asinh
  • atan
  • atanh
  • ceil
  • cos
  • cosh
  • deg
  • exp
  • floor
  • ln
  • log10
  • log2
  • rad
  • sgn
  • sin
  • sinh
  • sqrt
  • tan
  • tanh

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review June 20, 2024 07:10
@charleskorn charleskorn requested a review from a team as a code owner June 20, 2024 07:10
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was just about to add these :-)

@charleskorn charleskorn enabled auto-merge (squash) June 21, 2024 00:13
@charleskorn charleskorn merged commit 32bec9b into main Jun 21, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/trig-functions branch June 21, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants