-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTel resource attribute promotion feature #8271
Conversation
c9dc734
to
55055a3
Compare
Since we do label validation in validate.go validateLabels, check the number of label is less than the limit, if we convert resource attribute, we need to exclude those from numLabelNames
|
pushed a couple of tests on the blessing attributes, and a discussion about how to put lable limits |
0b8e46e
to
2ebad7f
Compare
@ying-jeanne we probably want to align with Loki, which includes the promoted attributes when comparing against the label count limit. |
7cf8362
to
fa127fd
Compare
9d6ddf4
to
a6bbd83
Compare
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
e97ad8a
to
c3235bf
Compare
0773dd8
to
39fdd1e
Compare
aa08f36
to
03ffca5
Compare
Signed-off-by: Arve Knudsen <[email protected]>
03ffca5
to
6f43162
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some small changes that I'd like you to take a look at.
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
What this PR does
Add support for promoting OTel resource attributes.
The flag
-distributor.promote-otel-resource-attributes
(also a runtime config parameter) controls which set of resource attributes to eventually promote.Additionally,
OTelResourceAttributePromotionConfig
can be set on the distributor configuration in order to specialize the configuration of which OTel resource attributes to promote. This is intended for our enterprise product.Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.