-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding global kedaAutoscaling
section
#7392
feat: Adding global kedaAutoscaling
section
#7392
Conversation
…ess, adding two new test cases
…, adding two test to better cover the local override for kedaAutoscaling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 💪 I'm not sure about the per-component overriding, I can't think of a use case for it.
not sure how the few incorrect manifests slipped in 🤔 I checked with the original PR and everything else seems correct
operations/helm/charts/mimir-distributed/templates/ruler/ruler-autoscaling.yaml
Outdated
Show resolved
Hide resolved
@dimitarvdimitrov I decided to remove the per component config, as you stated there will probably never be a realistic use case. And even if there would be in some edge case, this is a feature that does not need to be shipped to the majority of users. Further details of my thought process: #7392 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely done! I left only one more suggestion with some docs, otherwise LGTM
Co-authored-by: Dimitar Dimitrov <[email protected]>
What this PR does
This PR adds a global
kedaAutoscaling
section with the option to configure theprometheusAddress
,pollingInterval
&customHeaders
.Which issue(s) this PR fixes or relates to
Related to #7368
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.