OpenTelemetryTracerBridge.Start: Make returned context contain span #6614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/tracing
branch
from
2c0f0af to
fe04f81
Compare
ying-jeanne
reviewed
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
I found that there's a bug in
OpenTelemetryTracerBridge.Start, i.e. that the returned context doesn't contain ago.opentelemetry.io/otel/trace.Spanalthough it should. This PR fixes it, and adds a test for it.The practical effect of the bug is losing OpenTelemetry tracing events, e.g. in Prometheus, where code depends on fetching a span from the context (if no span is in the context, these events are discarded).
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]