mimir-build-image: Upgrade to Node.js 20 #6540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <[email protected]>
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version `grafana/mimir-build-image:pr6540-8b3fe039e9`. This can take up to 1 hour. |
pstibrany
approved these changes
Nov 2, 2023
|
@pstibrany do you have any idea where we use Node.js? I couldn't figure that out (main reason why the PR is a draft). |
3 tasks
This seems to be the only thing we need it for. |
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
requested review from
wilfriedroset,
vaxvms,
bubu11e and
a team
as code owners
|
Not building new version of mimir-build-image. This PR modifies `mimir-build-image/Dockerfile`, but the image `grafana/mimir-build-image:pr6540-8b3fe039e9` already exists. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Upgrade build image to latest Node.js LTS, v20. We are currently on v14, which is deprecated and produces a huge warning while building the image.
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]