Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krajo/merge from main to sparsehistograms #4390

Merged
merged 20 commits into from
Mar 6, 2023

Conversation

krajorama
Copy link
Contributor

No description provided.

krajorama and others added 20 commits March 2, 2023 09:23
* Helm: fix Kubernetes override for nginx HPA

The template did not take into account the override "kubeVersionOverride".
Fix by using the mimir template implemented for this reason.

Signed-off-by: György Krajcsovits <[email protected]>

* Helm: fix missing Kubernetes version overrides in tests

The golden record tests need a fixed version because helm uses the version
of the default context and can produce different results between
contributor's machine and the CI environment.

Add logic to test build to inject the minimal version if not found in the
values file. Mainly because we cannot have a version override in the
small and large values files.

Signed-off-by: György Krajcsovits <[email protected]>
Co-authored-by: Jon Kartago Lamida <[email protected]>
* Ruler: load more tenants in parallel during startup

* add more tests

* fix lint

* Apply suggestions from code review

Co-authored-by: Marco Pracucci <[email protected]>

* Ingester: fix OOO blocks labelling (#4297)

* Ingester: fix OOO blocks labelling

This fixes a bug where the OutOfOrderExternalLabel
was being added to all blocks instead of the ones coming
from OOO data, when the feature flag was enabled.

* Changelog

* PR number to changelog

* Update previous changelog entry instead

* Ruler: load more tenants in parallel during startup

* fix context

* improve unittest

---------

Co-authored-by: Marco Pracucci <[email protected]>
Co-authored-by: Nicolás Pazos <[email protected]>
* Upgrade mimir-prometheus to get a fast regexp path optimization

Signed-off-by: Marco Pracucci <[email protected]>

* Added CHANGELOG entry

Signed-off-by: Marco Pracucci <[email protected]>

---------

Signed-off-by: Marco Pracucci <[email protected]>
…RetentionExpires` (#4362)

* Use more specific assertion to include more information in test failures.

See #4198.

* Reduce flakiness of test by extending retention period.

This gives the rest of the test more time to retrieve `oldBlocks`
before any of the blocks is removed.
* Add asynchronous validation scaffolding for block upload

* addressed lint errors

* Update pkg/compactor/block_upload.go

Co-authored-by: Arve Knudsen <[email protected]>

* Update pkg/compactor/block_upload.go

Co-authored-by: Arve Knudsen <[email protected]>

* Update pkg/compactor/block_upload.go

Co-authored-by: Arve Knudsen <[email protected]>

* Update pkg/compactor/block_upload.go

Co-authored-by: Arve Knudsen <[email protected]>

* Update pkg/compactor/block_upload.go

Co-authored-by: Arve Knudsen <[email protected]>

* Update pkg/compactor/block_upload.go

Co-authored-by: Arve Knudsen <[email protected]>

* enable block upload for dev testing

* fixed validation errors, added debug log messages

* fixed cancelled context issue

* changed name of flag to disable complete block upload

* addressed reviewer feedback

* addressed reviewer feedback

* Address some review comments, WIP

* Small spacing cleanup

* Transition to in-memory bucket for block finish test

* Async validation test coordination, adding configuration flags

* Small comment and flag fix

* Swap config strategy, test still needs separation

* Docs + lint

* Review comments, begin separating tests

* Finish validateAndComplete test

* Update docs

* Remove docker compose arguments

* Regenerate rather than modify

* Review, add test for periodicValidationUpdater

* Make validateAndComplete test clearer, add upload meta check

* Set missing cancelContext

* Add sleep as suggested

* Configure data directory

* fixed compactor data dir in e2e test

* Add changelog entry

* Split into two entries

* Missing entry number

* Update CHANGELOG.md

---------

Co-authored-by: Arve Knudsen <[email protected]>
Co-authored-by: Andy Asp <[email protected]>
Co-authored-by: Andy Asp <[email protected]>
* change the default evaluation delay of ruler to 1m

* revert the changes in ruler test

* change integration test to set ruler default value

* fix integration tests

* Update integration/configs.go

Co-authored-by: Marco Pracucci <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Peter Štibraný <[email protected]>

---------

Co-authored-by: Marco Pracucci <[email protected]>
Co-authored-by: Peter Štibraný <[email protected]>
…when it is necessary (#4353)

* [Chore] update jsonnet manifest, avoid setting querier.frontend-address or create query-frontend-discovery when deployement mode is microserivces or query-scheduler is enabled

* linter and changelog

* Helm: fix parity with jsonnet on query frontend headless service

Do not generate query-frontend-headless service if query scheduler
 is enabled

Signed-off-by: György Krajcsovits <[email protected]>

* Apply suggestions from code review

Co-authored-by: Marco Pracucci <[email protected]>

* correct changelog

* regenerate helm golden files

* Update CHANGELOG.md

---------

Signed-off-by: György Krajcsovits <[email protected]>
Co-authored-by: György Krajcsovits <[email protected]>
Co-authored-by: Marco Pracucci <[email protected]>
* Spread TSDB head compaction over the configured interval

Signed-off-by: Marco Pracucci <[email protected]>

* Fixed unit test

Signed-off-by: Marco Pracucci <[email protected]>

* Apply suggestion from code review

Signed-off-by: Marco Pracucci <[email protected]>

* Fix typo in CHANGELOG entry

Signed-off-by: Marco Pracucci <[email protected]>

* Fix typo in CHANGELOG entry

Signed-off-by: Marco Pracucci <[email protected]>

---------

Signed-off-by: Marco Pracucci <[email protected]>
…rship spillover (#4381)

* Ruler: change deployment max surge and max unavailable to reduce ownership spillover

Signed-off-by: Marco Pracucci <[email protected]>

* Apply suggestions from code review

Co-authored-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Marco Pracucci <[email protected]>
Co-authored-by: Dimitar Dimitrov <[email protected]>
This note was in an unrelated section.

Signed-off-by: Oleg Zaytsev <[email protected]>
* Support histograms in pkg/storage and update other breakages

Signed-off-by: Ganesh Vernekar <[email protected]>
# Conflicts:
#	pkg/frontend/querymiddleware/querysharding_test_utils_test.go
#	pkg/frontend/querymiddleware/sharded_queryable.go
#	pkg/querier/matrix.go
#	pkg/storage/series/series_set.go
#	pkg/storage/series/series_set_test.go
#	pkg/util/chunkcompat/compat.go
#	pkg/util/modelutil/merger_test.go
@krajorama krajorama requested review from a team as code owners March 6, 2023 10:44
Copy link
Member

@codesome codesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the files from #4354 and they look good

@krajorama krajorama merged commit e4a37f9 into sparsehistogram Mar 6, 2023
@krajorama krajorama deleted the krajo/merge-from-main branch March 6, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants