Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest commit of dskit for cache updates #3896

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

56quarters
Copy link
Contributor

@56quarters 56quarters commented Jan 9, 2023

Signed-off-by: Nick Pillitteri [email protected]

What this PR does

This commit of dskit adds the ability to pass per-call options to cache calls. This allows callers to use specific memory allocators better suited to their workloads than GC.

Which issue(s) this PR fixes or relates to

See #3772

Checklist

  • Tests updated
  • [NA] Documentation added
  • [NA] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

This commit of dskit adds the ability to pass per-call options
to cache calls. This allows callers to use specific memory
allocators better suited to their workloads than GC.

See #3772

Signed-off-by: Nick Pillitteri <[email protected]>
@56quarters 56quarters marked this pull request as ready for review January 9, 2023 18:09
@56quarters 56quarters requested a review from a team as a code owner January 9, 2023 18:09
@pracucci pracucci self-requested a review January 10, 2023 14:51
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed these changes in dskit and LGTM.

@pracucci pracucci merged commit 2393f18 into main Jan 10, 2023
@pracucci pracucci deleted the 56quarters/dskit-update branch January 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants