Make namespace in build-helm-tests explicit #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitar Dimitrov <[email protected]>
Logiraptor
approved these changes
Jun 9, 2022
krajorama
reviewed
Jun 13, 2022
operations/helm/tests/build.sh
Outdated
| @@ -19,5 +19,5 @@ for FILEPATH in $TESTS; do | |||
| TEST_NAME=$(basename -s '.yaml' "$FILEPATH") | |||
|
|
|||
| echo "Templating $TEST_NAME" | |||
| helm template "${TEST_NAME}" ${CHART_PATH} -f "${FILEPATH}" --output-dir "operations/helm/tests/${TEST_NAME}-generated" | |||
| helm template "${TEST_NAME}" ${CHART_PATH} -f "${FILEPATH}" --output-dir "operations/helm/tests/${TEST_NAME}-generated" --namespace default | |||
There was a problem hiding this comment.
I think people would use mimir/GEM in a dedicated namespace in production. I'd rather we used some non standard name like "citestns" or something weird to grep easily. WDYT?
There was a problem hiding this comment.
I dont have a preference. I guess it doesnt hurt to have a non-standard namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Make namespace in build-helm-tests explicit. Otherwise, the namespace is taken from the current kubectl context.