Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making active series custom tracker configs marshalable for runtime c… #2065

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

gubjanos
Copy link
Contributor

@gubjanos gubjanos commented Jun 9, 2022

…onfig

What this PR does

Adding a MarshalYAML method to the CustomTrackersConfig as without it it is not Marshalled to the /runtime_config endpoint.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I've tested it manually and it works. Can you please add a unit test?

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pracucci pracucci merged commit a665934 into main Jun 10, 2022
@pracucci pracucci deleted the jg/active-series-runtime-fix branch June 10, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants