Add node and zonal antiaffinity to store gateway jsonnet #1730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Currently the Store Gateway jsonnet does not specify any antiAffinity for the zonal or regular running modes. This means that multiple storegateways can be on the same node in regular mode, or the same zone in zonal replication mode. This is obviously not ideal in the event of a failure.
To match the antiAffinity logic of the Ingester service, this PR adds a
storegateway_allow_multiple_replicas_on_same_node
option to jsonnet. It has the following behaviour:Notice with flag=true, existing behaviour is the same as prior to this change (no antiAffinity). With flag=false, it matches the Ingester's antiAffinity behaviour.
Which issue(s) this PR fixes or relates to
Fixes #1729
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]