Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mimir-continuous-test doc and CHANGELOG entry #1709

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

pracucci
Copy link
Collaborator

What this PR does

I've completed the planned work on mimir-continuous-test. In this PR I'm adding a CHANGELOG entry and documentation page.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci pracucci added the type/docs Improvements or additions to documentation label Apr 15, 2022
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just some language nits.

@pracucci
Copy link
Collaborator Author

Thanks @aknuds1. I will wait for @grafana/docs-squad to review.

@jdbaldry jdbaldry requested a review from osg-grafana April 15, 2022 16:07
Copy link
Contributor

@osg-grafana osg-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking with feebdack


- Using a local binary:

Download the appropriate [release asset](https://github.com/grafana/mimir/releases/latest) for your operating system and architecture and make it executable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Download the appropriate [release asset](https://github.com/grafana/mimir/releases/latest) for your operating system and architecture and make it executable.
Download the appropriate [Grafana Mimir release](https://github.com/grafana/mimir/releases/latest) for your operating system and architecture, and make it executable.

@pracucci pracucci force-pushed the add-mimir-continuous-test-doc branch from 23d449e to 1e70a04 Compare April 20, 2022 09:52
@pracucci pracucci enabled auto-merge (squash) April 20, 2022 09:52
@pracucci pracucci merged commit ea84cd6 into main Apr 20, 2022
@pracucci pracucci deleted the add-mimir-continuous-test-doc branch April 20, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants