Fix "Services' status" page content type #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was forced to be `text/plain` for some reason. Removed that forcing, and added an explicit setting of `text/html` in RenderHTTPResponse when it's not YAML (comment says it will render HTML, so it's safe). Signed-off-by: Oleg Zaytsev <[email protected]>
colega
changed the title
Signed-off-by: Oleg Zaytsev <[email protected]>
What is utf=8? Apparently my browser just ignored that. Signed-off-by: Oleg Zaytsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
It was forced to be
text/plainfor some reason. Removed that forcing, and added an explicit setting oftext/htmlin RenderHTTPResponse when it's not YAML (comment says it will render HTML, so it's safe).Which issue(s) this PR fixes or relates to
A new take to #1265
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]