-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Mimir 2.0.0-rc.0 #1253
Prepare Mimir 2.0.0-rc.0 #1253
Conversation
Signed-off-by: Marco Pracucci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I tried reading through twice but no doubt I've missed something since there are a lot of changes. Nothing leapt out as obviously wrong though.
@@ -865,14 +880,6 @@ | |||
* [CHANGE] Change default value of `-server.grpc.keepalive.min-time-between-pings` from `5m` to `10s` and `-server.grpc.keepalive.ping-without-stream-allowed` to `true`. #4168 | |||
* [CHANGE] Ingester: Change default value of `-ingester.active-series-metrics-enabled` to `true`. This incurs a small increase in memory usage, between 1.2% and 1.6% as measured on ingesters with 1.3M active series. #4257 | |||
* [CHANGE] Dependency: update go-redis from v8.2.3 to v8.9.0. #4236 | |||
* [CHANGE] Memberlist: Expose default configuration values to the command line options. Note that setting these explicitly to zero will no longer cause the default to be used. If the default is desired, then do set the option. The following are affected: #4276 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to confirm that this is removed as it is a "not user facing" change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't included in Cortex 1.10. It was then amended by Bryan, mentioned here:
cortexproject/cortex#4276 (comment)
In this PR I'm just fixing it here too, cause it has been removed from the final Cortex 1.10 changelog.
Where does the user know that nearly all the documentation will have been touched or rewritten? |
@osg-grafana It will be part of the release description, where we'll show some highlights about key changes and improvements, as as well as references to the new shining doc (including migration guide). |
Signed-off-by: Marco Pracucci <[email protected]> Co-authored-by: Jack Baldry <[email protected]>
What this PR does
In this PR:
VERSION
CHANGELOG
-
Out of scope: re-order CHANGELOG entries.
Which issue(s) this PR fixes
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]