MQE: Add support for label_join #10587
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
reviewed
Feb 5, 2025
| @@ -17,6 +18,43 @@ import ( | |||
| "github.com/grafana/mimir/pkg/streamingpromql/types" | |||
| ) | |||
|
|
|||
| func LabelJoinFactory(dstLabelOp, separatorOp types.StringOperator, srcLabelOp []types.StringOperator) SeriesMetadataFunction { | |||
There was a problem hiding this comment.
[nit]
Suggested change
| func LabelJoinFactory(dstLabelOp, separatorOp types.StringOperator, srcLabelOp []types.StringOperator) SeriesMetadataFunction { | |
| func LabelJoinFactory(dstLabelOp, separatorOp types.StringOperator, srcLabelOps []types.StringOperator) SeriesMetadataFunction { |
| @@ -173,6 +173,53 @@ func scalarToInstantVectorOperatorFactory(args []types.Operator, _ *limiting.Mem | |||
| return scalars.NewScalarToInstantVector(inner, expressionPosition), nil | |||
| } | |||
|
|
|||
| func LabelJoinFunctionOperatorFactory(args []types.Operator, memoryConsumptionTracker *limiting.MemoryConsumptionTracker, _ *annotations.Annotations, expressionPosition posrange.PositionRange, timeRange types.QueryTimeRange) (types.InstantVectorOperator, error) { | |||
| if len(args) < 3 { | |||
There was a problem hiding this comment.
Might be worth adding a note here that it's valid to have no source label names.
| } | ||
|
|
||
| lb.Reset(seriesMetadata[i].Labels) | ||
| lb.Set(dst, strings.Join(labelValues, separator)) |
There was a problem hiding this comment.
It'd be interesting to see if using the same strings.Builder here for every series would be more efficient - strings.Join uses a new strings.Builder under the covers for each call, so reusing the same one ourselves should allow us to avoid allocating a new buffer for every series.
Comment on lines
+16
to
+17
| # Prometheus fails this with enableDelayedNameRemoval disabled | ||
| # Can be tested against both once https://github.com/prometheus/prometheus/pull/15975 is merged |
There was a problem hiding this comment.
Looks like this has been merged - would you be able to vendor the fix into Mimir so we don't need to come back and move this later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.