Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet: allow to not configure topologySpreadConstraints at all #10540

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Jan 30, 2025

What this PR does

Allow to not configure topologySpreadConstraints by setting the following configuration options to a negative value:

  • distributor_topology_spread_max_skew
  • query_frontend_topology_spread_max_skew
  • querier_topology_spread_max_skew
  • ruler_topology_spread_max_skew
  • ruler_querier_topology_spread_max_skew
diff /Users/marco/workspace/src/github.com/grafana/mimir/operations/mimir-tests/test-all-components-generated.yaml /Users/marco/workspace/src/github.com/grafana/mimir/operations/mimir-tests/test-all-components-without-pod-topology-constraints-generated.yaml

563,569d562
<       topologySpreadConstraints:
<       - labelSelector:
<           matchLabels:
<             name: distributor
<         maxSkew: 1
<         topologyKey: kubernetes.io/hostname
<         whenUnsatisfiable: ScheduleAnyway
660,666d652
<       topologySpreadConstraints:
<       - labelSelector:
<           matchLabels:
<             name: querier
<         maxSkew: 1
<         topologyKey: kubernetes.io/hostname
<         whenUnsatisfiable: ScheduleAnyway
739,745d724
<       topologySpreadConstraints:
<       - labelSelector:
<           matchLabels:
<             name: query-frontend
<         maxSkew: 1
<         topologyKey: kubernetes.io/hostname
<         whenUnsatisfiable: ScheduleAnyway
905,911d883
<       topologySpreadConstraints:
<       - labelSelector:
<           matchLabels:
<             name: ruler
<         maxSkew: 1
<         topologyKey: kubernetes.io/hostname
<         whenUnsatisfiable: ScheduleAnyway

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@pracucci pracucci marked this pull request as ready for review January 30, 2025 14:52
@pracucci pracucci requested a review from a team as a code owner January 30, 2025 14:52
Copy link
Contributor

@duricanikolic duricanikolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci enabled auto-merge (squash) January 30, 2025 14:56
@pracucci pracucci merged commit 0b61a68 into main Jan 30, 2025
28 checks passed
@pracucci pracucci deleted the allow-to-disable-topology branch January 30, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants