MQE: fix functions that could return multiple series with the same labels #10533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/mqe-ensure-deduplicate-and-merge
branch
from
2312545 to
526732d
Compare
jhesketh
reviewed
Jan 29, 2025
| // This test ensures that all functions correctly merge series after dropping the metric name. | ||
| func TestFunctionDeduplicateAndMerge(t *testing.T) { | ||
| data := ` | ||
| load 30s |
There was a problem hiding this comment.
We should use spaces here as tabs don't ensure alignment for all
| "clamp_min": "-Inf", | ||
| "clamp_max": "Inf", | ||
| "label_replace": `"__name__", "$1", "env", "(.*)"`, | ||
| } |
There was a problem hiding this comment.
(nit) I feel like it would be simpler to just define a query string for each function, and then assert that the number of functions checked is equal to len(instantVectorFunctionOperatorFactories)
jhesketh
approved these changes
Jan 30, 2025
| require.NoError(t, err) | ||
| defer q.Close() | ||
|
|
||
| mimirResult := q.Exec(ctx) |
There was a problem hiding this comment.
I think we should consider passing this into Prometheus too so that we can verify we merge in the same way (as I think we've found a case previous where we don't).
Additionally, I think we should consider seeing if we can make this part of the gauntlet. ie make sure we have cases represented in there along with the selectors that would cause this to happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes an issue with the
clamp,clamp_min,clamp_max,roundandhistogram_fractionfunctions in MQE: they could return multiple series with the same labels if multiple series with the same labels but different metric names were passed to the function.This PR also adds a test to ensure we catch issues like these when new functions are added in the future.
Which issue(s) this PR fixes or relates to
#10067
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.