Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix flaky TestQuerier_ValidateQueryTimeRange_MaxQueryLength #10529

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

56quarters
Copy link
Contributor

What this PR does

Use a consistent value for "now" to ensure the error message matches the expected error in tests.

Which issue(s) this PR fixes or relates to

Fixes #10094

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Use a consistent value for "now" to ensure the error message matches
the expected error in tests.

Fixes #10094

Signed-off-by: Nick Pillitteri <[email protected]>
@56quarters 56quarters marked this pull request as ready for review January 28, 2025 21:09
@56quarters 56quarters requested a review from a team as a code owner January 28, 2025 21:09
@seizethedave seizethedave self-requested a review January 28, 2025 21:29
Copy link
Contributor

@seizethedave seizethedave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@56quarters 56quarters merged commit 266a393 into main Jan 28, 2025
28 checks passed
@56quarters 56quarters deleted the 56quarters/query-length-flake branch January 28, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky TestQuerier_ValidateQueryTimeRange_MaxQueryLength
2 participants