MQE Absent function #10523
MQE Absent function #10523
Conversation
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
| innerExpr parser.Expr | ||
| inner types.InstantVectorOperator | ||
| expressionPosition posrange.PositionRange | ||
| absentCount int |
There was a problem hiding this comment.
If I'm understanding your intention correctly, would innerSeriesCount be a clearer name?
There was a problem hiding this comment.
This is count how often the series is not there or being absent. But let me double check again according to the feedback in #10523 (comment) to ensure the correctness.
There was a problem hiding this comment.
I don't think this is correct - I think we're missing a few test cases that might flush out the correct behaviour:
- instant query over a selector that selects multiple series, each with a point at the query time
- instant query over an expression that could produce multiple series, but doesn't have any points (eg.
absent(metric_with_many_series > Inf)) - range query over a selector that selects a single series that does not have points at every time step in the range
- same as above, but with points at every time step in the range
- range query over a selector that selects multiple series that together don't have points at every time step in the range
- same as above, but where each time step has a sample in at least one series
- range query over an expression that could produce multiple series, but doesn't have any points (eg.
absent(metric_with_many_series > Inf))
There was a problem hiding this comment.
Thanks for the detailed feedback to ensure the correctness. I will add the test cases to ensure the correct behaviour.
| ) | ||
|
|
||
| // AbsentOperator is an operator that implements the absent() function. | ||
| type AbsentOperator struct { |
There was a problem hiding this comment.
[nit] We generally haven't used an Operator suffix for operators - I think Absent would be sufficient.
There was a problem hiding this comment.
[nit] This probably belongs in the functions package given it implements a function.
pkg/streamingpromql/functions.go
Outdated
| @@ -22,6 +23,7 @@ type InstantVectorFunctionOperatorFactory func( | |||
| annotations *annotations.Annotations, | |||
| expressionPosition posrange.PositionRange, | |||
| timeRange types.QueryTimeRange, | |||
| innerExpressions parser.Expressions, | |||
There was a problem hiding this comment.
[nit] Perhaps argumentExpressions would be a clearer name? Or argExpressions to maintain symmetry with args?
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
What this PR does
Implement absent function. Added a new
AbsentOperator. We also need to modifyInstantVectorFunctionOperatorFactoryto passparser.Expressionsobject needed to evaluate the labels of the absent argument.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.