Mimir: Add attributed prefix to labels of cost attribution metrics #10509
+69
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview available: https://deploy-preview-mimir-10509-zb444pucvq-vp.a.run.app/docs/mimir/latest/ |
tacole02
approved these changes
Jan 24, 2025
colega
reviewed
Jan 27, 2025
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| ### Grafana Mimir | |||
|
|
|||
| * [FEATURE] Ingester/Distributor: Add support for exporting cost attribution metrics (`cortex_ingester_attributed_active_series`, `cortex_distributor_received_attributed_samples_total`, and `cortex_discarded_attributed_samples_total`) with labels specified by customers to a custom Prometheus registry. This feature enables more flexible billing data tracking. #10269 | |||
| * [CHANGE] Ingester/Distributor: Prefix cost attribution metric labels with `attributed_` to prevent collisions with system cluster and namespace labels. #10509 | |||
There was a problem hiding this comment.
This is not needed because this new feature isn't included in any release yet.
There was a problem hiding this comment.
addressed here 97a5d77
colega
reviewed
Jan 27, 2025
pkg/costattribution/manager.go
Outdated
| @@ -21,6 +21,7 @@ const ( | |||
| defaultTrackerName = "cost-attribution" | |||
| missingValue = "__missing__" | |||
| overflowValue = "__overflow__" | |||
| usagePrefix = "attributed" | |||
There was a problem hiding this comment.
Nit, but I would expect the prefix to be attributed_.
There was a problem hiding this comment.
addressed in 97a5d77
colega
approved these changes
Jan 27, 2025
colega
reviewed
Jan 29, 2025
| func addLabelsPrefix(labels []string) []string { | ||
| out := make([]string, 0, len(labels)) | ||
| for _, l := range labels { | ||
| out = append(out, strings.Join([]string{usagePrefix, l}, "")) |
There was a problem hiding this comment.
This should be just:
Suggested change
| out = append(out, strings.Join([]string{usagePrefix, l}, "")) | |
| out = append(out, usagePrefix + l) |
colega
reviewed
Jan 29, 2025
| @@ -21,6 +21,7 @@ const ( | |||
| defaultTrackerName = "cost-attribution" | |||
| missingValue = "__missing__" | |||
| overflowValue = "__overflow__" | |||
| usagePrefix = "attributed_" | |||
There was a problem hiding this comment.
I'm not sure why is this called "usagePrefix", but I know naming is hard.
Maybe it could be exportedAttributedLabelPrefix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes or relates to
Users can set cost attribution labels for cluster and namespace, which may conflict with existing metrics that include a cluster label. To prevent this, cost attribution labels are prefixed, and the prefix can be removed later in the pipeline using recording rules.
Similar approach is implemented in Loki.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.