Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboards: fix latency comparison in "Mimir / Rollout Progress" #10495

Merged
merged 2 commits into from
Jan 22, 2025
Merged

dashboards: fix latency comparison in "Mimir / Rollout Progress" #10495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92086d1
dashboards: fix latency comparison in "Mimir / Rollout Progress"
dimitarvdimitrov Jan 22, 2025
6abd5cc
Add CHANGELOG.md entry
dimitarvdimitrov Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@

* [BUGFIX] Dashboards: fix how we switch between classic and native histograms. #10018
* [BUGFIX] Alerts: Ignore cache errors performing `delete` operations since these are expected to fail when keys don't exist. #10287
* [BUGFIX] Dashboards: fix "Mimir / Rollout Progress" latency comparison when gateway is enabled. #10495

### Jsonnet

Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-mixin/dashboards/rollout-progress.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ local filename = 'mimir-rollout-progress.json';
local config = $.queries {
namespace_matcher: $.namespaceMatcher(),
requests_per_second_metric: if $._config.gateway_enabled then $.queries.gateway.requestsPerSecondMetric else $.queries.distributor.requestsPerSecondMetric,
write_job_selector: if $._config.gateway_enabled then $.jobSelector($._config.job_names.gateway) else $.jobSelector($._config.job_names.distributor) + [utils.selector.re('route', $.queries.write_http_routes_regex)],
read_job_selector: if $._config.gateway_enabled then $.jobSelector($._config.job_names.gateway) else $.jobSelector($._config.job_names.query_frontend) + [utils.selector.re('route', $.queries.read_http_routes_regex)],
write_job_selector: (if $._config.gateway_enabled then $.jobSelector($._config.job_names.gateway) else $.jobSelector($._config.job_names.distributor)) + [utils.selector.re('route', $.queries.write_http_routes_regex)],
read_job_selector: (if $._config.gateway_enabled then $.jobSelector($._config.job_names.gateway) else $.jobSelector($._config.job_names.query_frontend)) + [utils.selector.re('route', $.queries.read_http_routes_regex)],
workload_label_replace_open:
std.repeat('label_replace(', std.length($._config.rollout_dashboard.workload_label_replaces)),
workload_label_replace_close:
Expand Down
Loading