blockbuilder: fix panic when closing tsdb after failing to upload block #10391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes a panic, I've noticed in a flaky test. When the
TSDBBuilder
fails to upload a block, the code ofCompactAndUpload
goes into the branches, that try to close the block several times. Consider the following case:tsdbs
, sees that B1 wasn't "done", and closes the block again;close of closed channel
and interrupts the clean-up;TSDBBuilder.Close
tries to close the blocks in thetsdbs
once again, and panics once again 🙈Also, I've notice there is a "race" condition, where the deferred clean-up function unlocks the mutex, that protects
tsdbs
before it cleans up thetsdbs
map.This PR fixes both issues and adds a unit test for the above scenario.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.