-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mimirtool): Make remote-read actually return data #10286
Conversation
Since #9156 probably, all the remote read commands return no data I added a missing error return using `timeseries.Err()` and got this error: `mimirtool: error: chunkedReader: message size exceeded the limit 0 bytes; got: 361 bytes, try --help` which lead me to find that we need to pass in `ChunkedReadLimit` on the client I set it at a default 1 MiB and configurable through a flag
a3fcceb
to
dfceee9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1MiB is also what mimir uses by default
mimir/pkg/querier/remote_read.go
Lines 37 to 40 in 7485d55
// Maximum number of bytes in frame when using streaming remote read. | |
// Google's recommendation is to keep protobuf message not larger than 1MB. | |
// https://developers.google.com/protocol-buffers/docs/techniques#large-data | |
maxRemoteReadFrameBytes = 1024 * 1024 |
SGTM, but maybe having something like 10-100MiB won't hurt so mimirtool is interoperable with other implementations that might choose slightly higher values.
I think the limit before the PR you linked was 50MiB, so we can restore that
|
Co-authored-by: Dimitar Dimitrov <[email protected]>
Since #9156 probably, all the remote read commands return no data
I added a missing error return using
timeseries.Err()
and got this error:mimirtool: error: chunkedReader: message size exceeded the limit 0 bytes; got: 361 bytes, try --help
which lead me to find that we need to pass inChunkedReadLimit
on the clientI set it at a default 1 MiB and configurable through a flag
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.