make generate-otlp: check that tools are installed
#10285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Zaytsev <[email protected]>
colega
commented
Dec 19, 2024
| # Use GNU sed on MacOS falling back to `sed` everywhere else | ||
| SED=sed | ||
| SED="sed" |
There was a problem hiding this comment.
Note: making shellcheck happy here.
NickAnge
approved these changes
Dec 19, 2024
56quarters
approved these changes
Jan 29, 2025
Would be great, but totally out of scope for me right now (I even forgot about this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Saves some time to the next developer who has to run
make generate-otlpand isn't familiar with the tools required.