-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example for alertmanager config with templates #10225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandro-verzicco
requested review from
tacole02 and
a team
as code owners
December 12, 2024 11:05
tacole02
approved these changes
Dec 12, 2024
dimitarvdimitrov
approved these changes
Dec 18, 2024
Thanks for the fix! |
sorry, can you rebase the branch onot grafana:main and push again? I don't know how else to try to get the CI to run. I can't merge the PR unless CI passes |
done |
now i know what it was. The new merge "experience ✨" in GitHub doesn't have the "Approve and run" button. I had to switch to the old one to approve the CI. Now CI is running. I'll merge on green. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Update documentation to make the
alertmanager.yml
config example coherent. In particular the example shows how to configure alertmanager with a custom alert template using mimirtool, but omits an important part: specifying the template file name in the alertmanager config. This will lead to a mis-configured alertmanager which will not send any notification and logs similar to:Which issue(s) this PR fixes or relates to
Fixes #7075
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.