Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example for alertmanager config with templates #10225

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

alessandro-verzicco
Copy link
Contributor

@alessandro-verzicco alessandro-verzicco commented Dec 12, 2024

What this PR does

Update documentation to make the alertmanager.yml config example coherent. In particular the example shows how to configure alertmanager with a custom alert template using mimirtool, but omits an important part: specifying the template file name in the alertmanager config. This will lead to a mis-configured alertmanager which will not send any notification and logs similar to:

caller=dispatch.go:353 level=error component=MultiTenantAlertmanager user=infra component=dispatcher insight=true component=dispatcher msg="Notify for alerts failed" num_alerts=1 err="slack-infra/slack[0]: notify retry canceled due to unrecoverable error after 1 attempts: template: :1:12: executing \"\" at <{{template \"standard_alert\" .}}>: template \"standard_alert\" not defined"

Which issue(s) this PR fixes or relates to

Fixes #7075

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@alessandro-verzicco alessandro-verzicco requested review from tacole02 and a team as code owners December 12, 2024 11:05
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2024

CLA assistant check
All committers have signed the CLA.

@dimitarvdimitrov dimitarvdimitrov enabled auto-merge (squash) December 18, 2024 14:13
@dimitarvdimitrov
Copy link
Contributor

Thanks for the fix!

auto-merge was automatically disabled December 19, 2024 09:05

Pull request was closed

@dimitarvdimitrov
Copy link
Contributor

sorry, can you rebase the branch onot grafana:main and push again? I don't know how else to try to get the CI to run. I can't merge the PR unless CI passes

@alessandro-verzicco
Copy link
Contributor Author

done

@dimitarvdimitrov
Copy link
Contributor

now i know what it was. The new merge "experience ✨" in GitHub doesn't have the "Approve and run" button. I had to switch to the old one to approve the CI. Now CI is running. I'll merge on green. Thanks again!

@dimitarvdimitrov dimitarvdimitrov enabled auto-merge (squash) December 19, 2024 09:54
@dimitarvdimitrov dimitarvdimitrov merged commit 45cd8ed into grafana:main Dec 19, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mimirtool: Templates fail to render (not defined)
4 participants