ruler: Register custom discovery config #10043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
arve/ruler-notifier-register
branch
from
5ec75cd to
e5a2509
Compare
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/ruler-notifier-register
branch
from
e5a2509 to
0ee589c
Compare
fionaliao
reviewed
Nov 28, 2024
fionaliao
approved these changes
Nov 29, 2024
colega
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
With Prometheus 3, it's required to register custom
discovery.Configimplementations, otherwise they cannot be marshaled. This currently causes Grafana Enterprise Metrics test failures in PRs to re-vendor Mimir.Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.