Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet: rename autoscaling_distributor_[min|max]_replicas to autoscaling_distributor_[min|max]_replicas_per_zone #10019

Merged
merged 1 commit into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@
* [CHANGE] Rollout-operator now defaults to storing scaling operation metadata in a Kubernetes ConfigMap. This avoids recursively invoking the admission webhook in some Kubernetes environments. #9699
* [CHANGE] Update rollout-operator version to 0.20.0. #9995
* [CHANGE] Remove the `track_sizes` feature for Memcached pods since it is unused. #10032
* [CHANGE] The configuration options `autoscaling_distributor_min_replicas` and `autoscaling_distributor_max_replicas` has been renamed to `autoscaling_distributor_min_replicas_per_zone` and `autoscaling_distributor_max_replicas_per_zone` respectively. #10019
* [FEATURE] Add support to deploy distributors in multi availability zones. #9548
* [FEATURE] Add configuration settings to set the number of Memcached replicas for each type of cache (`memcached_frontend_replicas`, `memcached_index_queries_replicas`, `memcached_chunks_replicas`, `memcached_metadata_replicas`). #9679
* [ENHANCEMENT] Add `ingest_storage_ingester_autoscaling_triggers` option to specify multiple triggers in ScaledObject created for ingest-store ingester autoscaling. #9422
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-autoscaling.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ mimir {
autoscaling_ruler_querier_max_replicas: 30,

autoscaling_distributor_enabled: true,
autoscaling_distributor_min_replicas: 3,
autoscaling_distributor_max_replicas: 30,
autoscaling_distributor_min_replicas_per_zone: 3,
autoscaling_distributor_max_replicas_per_zone: 30,

autoscaling_query_frontend_enabled: true,
autoscaling_query_frontend_min_replicas: 3,
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-multi-zone-distributor.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
multi_zone_availability_zones: availabilityZones,

autoscaling_distributor_enabled: true,
autoscaling_distributor_min_replicas: 3,
autoscaling_distributor_max_replicas: 30,
autoscaling_distributor_min_replicas_per_zone: 3,
autoscaling_distributor_max_replicas_per_zone: 30,
},
}
8 changes: 4 additions & 4 deletions operations/mimir/autoscaling.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
autoscaling_ruler_querier_workers_target_utilization: 0.75, // Target to utilize 75% ruler-querier workers on peak traffic, so we have 25% room for higher peaks.

autoscaling_distributor_enabled: false,
autoscaling_distributor_min_replicas: error 'you must set autoscaling_distributor_min_replicas in the _config',
autoscaling_distributor_max_replicas: error 'you must set autoscaling_distributor_max_replicas in the _config',
autoscaling_distributor_min_replicas_per_zone: error 'you must set autoscaling_distributor_min_replicas_per_zone in the _config',
autoscaling_distributor_max_replicas_per_zone: error 'you must set autoscaling_distributor_max_replicas_per_zone in the _config',
autoscaling_distributor_cpu_target_utilization: 1,
autoscaling_distributor_memory_target_utilization: 1,

Expand Down Expand Up @@ -551,8 +551,8 @@
container_name='distributor',
cpu_requests=$.distributor_container.resources.requests.cpu,
memory_requests=$.distributor_container.resources.requests.memory,
min_replicas=$._config.autoscaling_distributor_min_replicas,
max_replicas=$._config.autoscaling_distributor_max_replicas,
min_replicas=$._config.autoscaling_distributor_min_replicas_per_zone,
max_replicas=$._config.autoscaling_distributor_max_replicas_per_zone,
cpu_target_utilization=$._config.autoscaling_distributor_cpu_target_utilization,
memory_target_utilization=$._config.autoscaling_distributor_memory_target_utilization,
with_cortex_prefix=true,
Expand Down