Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mixtool #1617

Closed
pracucci opened this issue Apr 4, 2022 · 1 comment
Closed

Upgrade mixtool #1617

pracucci opened this issue Apr 4, 2022 · 1 comment
Labels
jsonnet

Comments

@pracucci
Copy link
Collaborator

pracucci commented Apr 4, 2022

The mixtool version used in mimir-build-image is quite old and we should update it. I've pushed an updated build image with the latest mixtool commit, but dashboard linter shows many failures. We should investigate and fix it:
https://github.com/grafana/mimir/compare/update-mixtool

It's not high priority.
@pracucci pracucci mentioned this issue Apr 4, 2022
Merged
3 tasks
julienduchesne added a commit that referenced this issue Aug 27, 2024
@julienduchesne
Run mixtool in container
52bf88b 
Also updates mixtool to latest version which closes #1617
Mixtool was actually updated two months ago, so the dashboards are already all compliant!

For the Makefile changes, I was looking at the issue above and I wanted to test it using the build image. I noticed that it wasn't actually running in the container. This should make it easier to test in the future.
@julienduchesne julienduchesne mentioned this issue Aug 27, 2024
Closed
@pracucci
Copy link
Collaborator Author

Done in #8032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
jsonnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

makefile: Run mixtool in container grafana/mimir
1 participant
@pracucci