Update comments about dynamic replication grace period

Signed-off-by: Nick Pillitteri <[email protected]>
grafana · Jan 14, 2025 · 744614e · 744614e
1 parent 101af2f
commit 744614e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkg/querier/blocks_store_queryable.go b/pkg/querier/blocks_store_queryable.go
@@ -248,8 +248,8 @@ func NewBlocksStoreQueryableFromConfig(querierCfg Config, gatewayCfg storegatewa
 	if gatewayCfg.DynamicReplication.Enabled {
 		dynamicReplication = storegateway.NewMaxTimeDynamicReplication(
 			gatewayCfg.DynamicReplication.MaxTimeThreshold,
-			// Exclude blocks which have recently become eligible for expanded replication, in order to give
-			// enough time to store-gateways to discover and load them (3 times the sync interval)
+			// Keep syncing blocks to store-gateways for a grace period (3 times the sync interval) to
+			// ensure they are not unloaded while they are still being queried.
 			mimir_tsdb.NewBlockDiscoveryDelayMultiplier*storageCfg.BucketStore.SyncInterval,
 		)
 	}

diff --git a/pkg/storegateway/gateway.go b/pkg/storegateway/gateway.go
@@ -183,8 +183,8 @@ func newStoreGateway(gatewayCfg Config, storageCfg mimir_tsdb.BlocksStorageConfi
 	if gatewayCfg.DynamicReplication.Enabled {
 		dynamicReplication = NewMaxTimeDynamicReplication(
 			gatewayCfg.DynamicReplication.MaxTimeThreshold,
-			// Exclude blocks which have recently become eligible for expanded replication, in order to give
-			// enough time to store-gateways to discover and load them (3 times the sync interval)
+			// Keep syncing blocks to store-gateways for a grace period (3 times the sync interval) to
+			// ensure they are not unloaded while they are still being queried.
 			mimir_tsdb.NewBlockDiscoveryDelayMultiplier*storageCfg.BucketStore.SyncInterval,
 		)
 	}