Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OOO Native Histogram counter reset query tests #570

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Add OOO Native Histogram counter reset query tests #570

merged 1 commit into from
Jan 9, 2024

Conversation

carrieedwards
Copy link
Contributor

This PR adds tests for OOO Native Histograms with counter resets on the query side.

@fionaliao fionaliao force-pushed the cedwards/ooo-native-histograms branch from 86a2683 to a560cb3 Compare November 29, 2023 19:21
fionaliao
fionaliao reviewed Dec 27, 2023
View reviewed changes
Copy link
Contributor

@fionaliao fionaliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test structure looks good, I mostly made some cleanup comments

@carrieedwards carrieedwards marked this pull request as ready for review January 2, 2024 17:51
@carrieedwards carrieedwards force-pushed the cedwards/ooo-native-histograms-counter-reset-query-tests branch from 808adcf to 4c30e3a Compare January 3, 2024 18:00
fionaliao
fionaliao reviewed Jan 4, 2024
View reviewed changes
fionaliao
fionaliao approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@fionaliao fionaliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for adding the counter reset header explanation

@carrieedwards carrieedwards force-pushed the cedwards/ooo-native-histograms branch 4 times, most recently from b02a0e9 to fab5b45 Compare January 9, 2024 20:35
@carrieedwards carrieedwards force-pushed the cedwards/ooo-native-histograms-counter-reset-query-tests branch from 4e9969f to de4495a Compare January 9, 2024 21:31
@carrieedwards carrieedwards force-pushed the cedwards/ooo-native-histograms-counter-reset-query-tests branch from de4495a to 5379567 Compare January 9, 2024 22:22
@carrieedwards carrieedwards merged commit 1cd2c60 into cedwards/ooo-native-histograms Jan 9, 2024
5 checks passed
@carrieedwards carrieedwards deleted the cedwards/ooo-native-histograms-counter-reset-query-tests branch January 9, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fionaliao fionaliao fionaliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carrieedwards @fionaliao