Get Release Helm chart Github action working #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hollands <[email protected]>
Signed-off-by: Michel Hollands <[email protected]>
Signed-off-by: Michel Hollands <[email protected]>
Signed-off-by: Michel Hollands <[email protected]>
Signed-off-by: Michel Hollands <[email protected]>
Signed-off-by: Michel Hollands <[email protected]>
Signed-off-by: Michel Hollands <[email protected]>
Signed-off-by: Michel Hollands <[email protected]>
Signed-off-by: Michel Hollands <[email protected]>
Signed-off-by: Michel Hollands <[email protected]>
trevorwhitney
approved these changes
Apr 22, 2024
| @@ -8,9 +8,6 @@ env: | |||
| CR_PACKAGE_PATH: "${{ github.workspace }}/.cr-release-packages" | |||
| CR_TOOL_PATH: "${{ github.workspace }}/.cr-tool" | |||
| CR_VERSION: "1.5.0" | |||
| permissions: | |||
| contents: read | |||
| id-token: write | |||
There was a problem hiding this comment.
don't you need the id-token for the github app token to work?
There was a problem hiding this comment.
No, it works without. A v0.0.1 release was built.
There was a problem hiding this comment.
I am using the actions/create-github-app-token@v1 action. That creates a token from the github app app-ID and private key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This based on #66 which took the Helm chart publishing code from https://github.com/grafana/k8s-monitoring-helm.