Service selector for single binary deployment fix. #7301
Conversation
|
|
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
There was a problem hiding this comment.
Hey @besteban1989 .
Huge thanks for the contribution.
Also, statefulset might add additional labels defined by user in .Values.singleBinary.selectorLabels . see:
https://github.com/grafana/loki/blob/main/production/helm/loki/templates/single-binary/statefulset.yaml#L33-L36
Could you please also add this part here?
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
|
@vlad-diachenko the change is done, pls review and approve if everything is ok. |
Bumped version of the chart and added changelog. These changes were missed in #7301
Single binary deployment is not working when going through default service. The issue is with the labels that currently includes the canary pods. Fixes grafana#7260
Bumped version of the chart and added changelog. These changes were missed in grafana#7301
Single binary deployment is not working when going through default service. The issue is with the labels that currently includes the canary pods. Fixes grafana#7260
Bumped version of the chart and added changelog. These changes were missed in grafana#7301
Single binary deployment is not working when going through default service. The issue is with the labels that currently includes the canary pods. Fixes grafana#7260
Bumped version of the chart and added changelog. These changes were missed in grafana#7301
Single binary deployment is not working when going through default service. The issue is with the labels that currently includes the canary pods. Fixes grafana#7260
Bumped version of the chart and added changelog. These changes were missed in grafana#7301
Single binary deployment is not working when going through default service. The issue is with the labels that currently includes the canary pods.
Fixes #7260