logcli: Query needs to be stored into url.RawQuery, and not url.Path #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logcli put path + query string into
url.Pathfield, which was then path-encoded into:https://logs-dev-ops-tools1.grafana.net/loki/api/v1/query_range%3Fdirection=BACKWARD&end=1588318369339918000&limit=30&query=%257Bnamespace%253D%2522loki-ops2%2522%257D&start=1588314769339918000which doesn't work.
Query needs to be stored into
RawQueryfield instead to be correctly encoded as a query string after?.This PR also removes now unused
EncodeWithPathmethod from QueryStringBuilder.Related to #2000, which introduced
buildURLfunction.