Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace experimental maps and slices with stdlib #15051

Merged
merged 3 commits into from
Nov 27, 2024
Merged

refactor: replace experimental maps and slices with stdlib #15051

merged 3 commits into from
Nov 27, 2024

Conversation

Juneezee
Copy link
Contributor

What this PR does / why we need it:

The experimental functions are now available in the standard library since Go 1.23 1.

The only difference is that maps.Keys and maps.Values in the standard library return an iterator, while maps.Keys and maps.Values in the golang.org/x/exp package return a slice.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Footnotes

  1. https://go.dev/doc/go1.23#new-unique-package

@Juneezee Juneezee requested a review from a team as a code owner November 21, 2024 10:28
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@cyriltovena cyriltovena merged commit 062d1e9 into grafana:main Nov 27, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants