chore: remove submodule accidentally added to repo #14883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoBraveCoding
approved these changes
Nov 12, 2024
|
Thanks for the review, @JoaoBraveCoding , but I'm not merging this as this is not inside our directory 🙂 |
|
cc @trevorwhitney , might be relevant to you, as I have seen you make comments on the linked helm PRs. |
trevorwhitney
approved these changes
Nov 15, 2024
|
Fixes #14896 |
This was referenced Nov 15, 2024
thevops
pushed a commit
to thevops/loki
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The submodule was accidentally added in #14570 .
Should we add this path to the ignores? The
helm-weekly-release.shscript seems to create this temporarily, but it gets added to the PR. Currently open PRs update it as well: #14871 #14872Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)