refactor(blooms): Forward created metas from builder to planner #13133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvacorts
force-pushed
the
salvacorts/bloom-refactor/builder-send-back-metas
branch
from
aca3280 to
8d89a53
Compare
chaudum
reviewed
Jun 5, 2024
| } | ||
|
|
||
| func (r *TaskResult) ToProtoTaskResult() *ProtoTaskResult { | ||
| if r.Error != nil { |
There was a problem hiding this comment.
nit: return nil if r == nil
pkg/bloombuild/planner/planner.go
Outdated
| }() | ||
|
|
||
| taskTimeout := p.limits.BuilderResponseTimeout(task.Tenant) | ||
| if taskTimeout == 0 { | ||
| // If the timeout is 0 (disabled), just wait for the builder to respond | ||
| return <-errCh | ||
| result := <-resultsCh | ||
| return result.Error |
There was a problem hiding this comment.
nit: add TODO: process result
There was a problem hiding this comment.
Refactored the function a bit for better readability
chaudum
approved these changes
Jun 5, 2024
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We forward the list of created metas from the builder to the planner so we can later compute the outdated metas and blocks for deletion.
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR