Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Republish the sizing calculator but don't list it in the table of contents and don't index it #13070

Merged
merged 3 commits into from
May 30, 2024

Conversation

jdbaldry
Copy link
Member

What this PR does / why we need it:
The link to the Loki public sizing calculator displays “We can’t find this page….” ?
Is this an error, or are we intending to stop using this public calculator?

The calculator was removed in #12598 because it was deemed to be too inaccurate but SEs would like to continue to use it with that understanding.

Which issue(s) this PR fixes:
https://raintank-corp.slack.com/archives/C01LEA0NMFT/p1714505902504099

@jdbaldry jdbaldry requested a review from a team as a code owner May 29, 2024 16:48
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label May 29, 2024
@grafanabot
Copy link
Collaborator

Hello @jdbaldry!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

1 similar comment
@grafanabot
Copy link
Collaborator

Hello @jdbaldry!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@JStickler JStickler changed the title Republish the sizing calculator but don't list it in the table of contents and don't index it docs: Republish the sizing calculator but don't list it in the table of contents and don't index it May 29, 2024
@JStickler JStickler merged commit 21dd4af into main May 30, 2024
60 checks passed
@JStickler JStickler deleted the jdbaldry-patch-1 branch May 30, 2024 13:34
grafanabot pushed a commit that referenced this pull request May 30, 2024
…of contents and don't index it (#13070)

Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 21dd4af)
grafanabot pushed a commit that referenced this pull request May 30, 2024
…of contents and don't index it (#13070)

Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 21dd4af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.9.x backport release-3.0.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants