Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): add support for additional PodLogs pipeline stages in selfMonitoring #12389

Merged
merged 5 commits into from
Mar 28, 2024
Merged

feat(helm): add support for additional PodLogs pipeline stages in selfMonitoring #12389

merged 5 commits into from
Mar 28, 2024

Conversation

dannykopping
Copy link
Contributor

@dannykopping dannykopping commented Mar 28, 2024 •
edited
Loading

What this PR does / why we need it:
The PodLogs resource currently only supports a single pipeline stage (cri), and I need it to at least support configuring the docker stage as well; figured it'd make more sense to just allow arbitrary stages.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Miss you guys!!

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@dannykopping dannykopping requested a review from a team as a code owner March 28, 2024 09:08
@dannykopping dannykopping changed the title Helm: add support for additional Podlogs pipeline stages in selfMonitoring Helm: add support for additional PodLogs pipeline stages in selfMonitoring Mar 28, 2024
@dannykopping dannykopping changed the title Helm: add support for additional PodLogs pipeline stages in selfMonitoring feat(helm): add support for additional PodLogs pipeline stages in selfMonitoring Mar 28, 2024
@dannykopping
Update version
777a331 
Signed-off-by: Danny Kopping <[email protected]>
@dannykopping
make documentation-helm-reference-check
187bf35 
Signed-off-by: Danny Kopping <[email protected]>
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 28, 2024
MichelHollands
MichelHollands approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Danny, how are things? I left 1 comment, otherwise looking fine.

production/helm/loki/CHANGELOG.md
@@ -13,6 +13,11 @@ Entries should include a reference to the pull request that introduced the chang

[//]: # (<AUTOMATED_UPDATES_LOCATOR> : do not remove this line. This locator is used by the CI pipeline to automatically create a changelog entry for each new Loki release. Add other chart versions and respective changelog entries bellow this line.)

## 5.47.2

- [ENHANCEMENT] Allow for additional pipeline stages to be configured on the `selfMonitoring` `Podlogs` resource.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, bad rebase
Fixed 👍

@dannykopping
Fix CHANGELOG
3a165a3 
Signed-off-by: Danny Kopping <[email protected]>
@dannykopping
Copy link
Contributor Author

Hey Danny, how are things? I left 1 comment, otherwise looking fine.

All good man! Hope all's well with you too?
Thanks for the quick review.

I'll likely be pushing a few more enhancements in the next few days & weeks; we're going to be rolling the Loki SSD chart in a separate observability chart for https://github.com/coder/coder ❤️

@dannykopping
Copy link
Contributor Author

@MichelHollands could you approve the build please?

@MichelHollands
Copy link
Contributor

@MichelHollands could you approve the build please?

Sorry, I forgot that we have to do that for your PRs now. It's running.

@MichelHollands MichelHollands merged commit 111c19b into grafana:main Mar 28, 2024
13 checks passed
@dannykopping dannykopping deleted the dannykopping/pod-logs-pipelines branch March 28, 2024 11:20
@slim-bean
Copy link
Collaborator

@dannykopping just a heads up that we are deprecating the monitoring sections of this chart in the next release (very soon with 3.0) and encouraging folks to use https://github.com/grafana/meta-monitoring-chart

rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@dannykopping @rhnasc
feat(helm): add support for additional PodLogs pipeline stages in `…
2d1deb0 
…selfMonitoring` (grafana#12389)

Signed-off-by: Danny Kopping <[email protected]>
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@dannykopping
feat(helm): add support for additional PodLogs pipeline stages in `…
afe1dc2 
…selfMonitoring` (grafana#12389)

Signed-off-by: Danny Kopping <[email protected]>
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
area/helm size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannykopping @MichelHollands @slim-bean