-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Update the prometheus dependency of Loki and Promtail #12245
Conversation
44839b2
to
5fed91e
Compare
This commit also does a "go mod tidy" and a "go mod vendor".
5fed91e
to
fcc8daa
Compare
@chaudum I tested the Promtail code by running a local Promtail with this config: Promtail configserver:
http_listen_port: 9080
grpc_listen_port: 0
enable_runtime_reload: true
positions:
filename: /Users/paulintodev/Desktop/log_metrics_bug/tmp_promtail/positions
clients:
- url: ""
basic_auth:
username: ""
password: ""
scrape_configs:
- job_name: log files
consulagent_sd_configs:
docker_sd_configs:
file_sd_configs:
static_configs:
- labels:
__path__: /Users/paulintodev/Desktop/log_metrics_bug/*.log I also ran a Promtail using the code form the This is a correct side-effect of the latest Prometheus code. Promtail doesn't even use the Prometheus components which output those metrics, so I think it's safe to remove them. I will need you to confirm a few things please:
|
344aa54
to
65e8b33
Compare
This is no longer needed, because the code was copied to Prometheus: "github.com/prometheus/prometheus/storage/remote/otlptranslator/prometheus"
65e8b33
to
5c501ad
Compare
5c501ad
to
0c2a2c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling the Prometheus dependency upgrade!
This PR updates the Prometheus dependency in Loki and Promtail. The PR is required so that we can also update Grafana Agent to the latest Prometheus. Unfortunately, Promtail and Loki share the same go.mod file.
This PR updates the Prometheus dependency in Loki and Promtail. The PR is required so that we can also update Grafana Agent to the latest Prometheus. Unfortunately, Promtail and Loki share the same go.mod file.
What this PR does / why we need it:
This PR updates the Prometheus dependency of Loki and Promtail. The PR is required so that we can also update Grafana Agent to the latest Prometheus. Unfortunately, Promtail and Loki share the same go.mod file. I am not able to update only Promtail.
Special notes for your reviewer:
pkg/ruler
use a registry which is wrapped by labels such as user ID. I hope the cardinality of SD metrics won't increase too much now that the SD metrics will be using this wrapped registry too.Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR