Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k167] Fix regression when parsing numbers in Push request #10551

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

grafanabot
Copy link
Collaborator

Backport 5ab9515 from #10550


What this PR does / why we need it:
Even though the Loki HTTP API docs for the push endpoint state that the stream label values should be strings, we previously didn't enforce this requirement. With #9694, we started enforcing this requirement, and that broke some users.

In this PR we are reverting this type of assertion and adding a bunch of tests to avoid the regression in the future.

**What this PR does / why we need it**:
Even though the[ Loki HTTP API docs for the push endpoint][1] state that
the stream label values should be strings, we previously didn't enforce
this requirement. With #9694, we
started enforcing this requirement, and that broke some users.

In this PR we are reverting this type of assertion and adding a bunch of
tests to avoid the regression in the future.

[1]:
https://grafana.com/docs/loki/latest/reference/api/#push-log-entries-to-loki

(cherry picked from commit 5ab9515)
@grafanabot grafanabot requested a review from a team as a code owner September 12, 2023 07:51
@grafanabot grafanabot added backport size/L type/bug Somehing is not working as expected labels Sep 12, 2023
@salvacorts salvacorts merged commit 886430d into k167 Sep 12, 2023
@salvacorts salvacorts deleted the backport-10550-to-k167 branch September 12, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/L type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants