chore(loki): Have fewer go.mod and go.sum
#10023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have some different tools use their own versions of dependencies with their own go.mod and go.sum files. This PR try to have single (go.mod and go.sum) dependencies. One exception is may be the `/operator`. Leaving that out of scope now because that may need some more consensus and will take it different PR. Another exception is `/pkg/push` package Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
1 task
kavirajk
added a commit
that referenced
this pull request
Jul 24, 2023
**What this PR does / why we need it**: This introduces following changes 1. change open-pull-requests-limit from 2 -> 5 for root level go.mod dependencies 2. Add dependabot also other go.mod files in `/operator`. 3. Add dependabot tracking for docker images under `/cmd/loki/` **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: NOTES: 1. [There is go.mod cleanup PR open ](#10023) that make most some internal tools to use just one `go.mod` at the root level. 2. Will add tracking to other docker images in other directories in follow up PR **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) Signed-off-by: Kaviraj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently we have some different tools(inspect-chunk, lambda-promtail, etc) use their own versions of dependencies with their own
go.modandgo.sumfiles.This PR try to have single (go.mod and go.sum) dependencies for those tools.
One exception is may be the
/operator. Leaving that out of scope now because that may need some more consensus and will take it different PR.Another exception is
/pkg/pushpackage. Introduce via this PR with some valid use case.Which issue(s) this PR fixes:
Fixes #NA
Special notes for your reviewer:
One of the main rationale for this is to make easy to track our dependencies (if it's on fewer places) and automate upgrades (for easy version upgrades and security patch upgrades)
Ignoring changes on
/vendordirectory, The changes are only in couple of directories and maingo.modandgo.sumfiles.Checklist
CONTRIBUTING.mdguide (required)