Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Backend Pods Don't Support Extra Containers #16164

Closed
mgbz89 opened this issue Feb 10, 2025 · 1 comment · Fixed by #16205
Closed

Helm: Backend Pods Don't Support Extra Containers #16164

mgbz89 opened this issue Feb 10, 2025 · 1 comment · Fixed by #16205

Comments

@mgbz89
Copy link
Contributor

mgbz89 commented Feb 10, 2025

Is your feature request related to a problem? Please describe.
When deploying Loki in Simple Scalable Mode using the Helm chart, you can attach a sidecar container to the Write and Read components, however, you cannot do so with the Backend component.

Describe the solution you'd like
The Loki Helm chart should support adding a sidecar container to each of the Simple Scalable Mode components. In the past, there were PRs to add this capability to the Write component and Read component. I'd like to complete this by creating a very similar PR for the Backend component.

Describe alternatives you've considered
We could patch the StatefulSet directly, but we would like to be able to make use of the Helm chart and future improvements to the Helm chart.

Additional context
Previous MRs:

@mgbz89
Copy link
Contributor Author

mgbz89 commented Feb 10, 2025

I'm happy to create a PR this week, if this change would be accepted

DylanGuedes pushed a commit that referenced this issue Mar 7, 2025
**What this PR does / why we need it**:
This PR adds the `extraContainers` property to the backend Loki pods for the Loki helm chart.

**Which issue(s) this PR fixes**:
Fixes #16164
JoaoBraveCoding pushed a commit to JoaoBraveCoding/loki that referenced this issue Mar 12, 2025
**What this PR does / why we need it**:
This PR adds the `extraContainers` property to the backend Loki pods for the Loki helm chart.

**Which issue(s) this PR fixes**:
Fixes grafana#16164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants