Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong api endpoiont in fluent-plugin-grafana-loki #1307

Closed
Horkyze opened this issue Nov 22, 2019 · 1 comment · Fixed by #1326
Closed

Wrong api endpoiont in fluent-plugin-grafana-loki #1307

Horkyze opened this issue Nov 22, 2019 · 1 comment · Fixed by #1326

Comments

@Horkyze
Copy link
Contributor

Horkyze commented Nov 22, 2019

Describe the bug
Since loki 1.0.0 is now using api /api/v1/* shouldnt this be reflected in here?

loki/fluentd/fluent-plugin-grafana-loki/lib/fluent/plugin/out_loki.rb

Line 121 in fd25e6d

uri = URI.parse(url + '/api/prom/push')

@slim-bean
Copy link
Collaborator

yes absolutely this should be updated, would you be willing to open a PR?

dawidmalina added a commit to dawidmalina/loki that referenced this issue Nov 27, 2019
@dawidmalina
Wrong api endpoiont in fluent-plugin-grafana-loki
434cf8b 
Closes: grafana#1307
@dawidmalina dawidmalina mentioned this issue Nov 27, 2019
Merged
cyriltovena pushed a commit that referenced this issue Nov 27, 2019
@dawidmalina @cyriltovena
Wrong api endpoiont in fluent-plugin-grafana-loki (#1326)
4202ced 
Closes: #1307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrong api endpoint in fluent-plugin-grafana-loki dawidmalina/loki
2 participants
@Horkyze @slim-bean