Fixes all lint errors. (#2768)

Signed-off-by: Cyril Tovena <[email protected]>

cmd/loki/main.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"os"
 	"reflect"
-	"strings"
 
 	"github.com/cortexproject/cortex/pkg/util/flagext"
 	"github.com/go-kit/kit/log/level"
@@ -28,8 +27,6 @@ func init() {
 	prometheus.MustRegister(version.NewCollector("loki"))
 }
 
-var lineReplacer = strings.NewReplacer("\n", "\\n  ")
-
 type Config struct {
 	loki.Config  `yaml:",inline"`
 	printVersion bool

pkg/canary/reader/reader.go

@@ -434,6 +434,6 @@ func nextBackoff(w io.Writer, statusCode int, backoff *util.Backoff) time.Time {
 	} else {
 		next = time.Now().Add(backoff.NextDelay())
 	}
-	fmt.Fprintf(w, "Loki returned an error code: %v, waiting %v before next query.", statusCode, next.Sub(time.Now()))
+	fmt.Fprintf(w, "Loki returned an error code: %v, waiting %v before next query.", statusCode, time.Until(next))
 	return next
 }

pkg/distributor/distributor.go

@@ -263,8 +263,8 @@ func (d *Distributor) Push(ctx context.Context, req *logproto.PushRequest) (*log
 	}
 
 	tracker := pushTracker{
-		done:           make(chan struct{}),
-		err:            make(chan error),
+		done: make(chan struct{}),
+		err:  make(chan error),
 	}
 	tracker.samplesPending.Store(int32(len(streams)))
 	for ingester, samples := range samplesByIngester {

pkg/ingester/flush.go

@@ -307,7 +307,7 @@ func (i *Ingester) removeFlushedChunks(instance *instance, stream *stream) {
 	}
 }
 
-func (i *Ingester) flushChunks(ctx context.Context, fp model.Fingerprint, labelPairs labels.Labels, cs []*chunkDesc, streamsMtx *sync.RWMutex) error {
+func (i *Ingester) flushChunks(ctx context.Context, fp model.Fingerprint, labelPairs labels.Labels, cs []*chunkDesc, streamsMtx sync.Locker) error {
 	userID, err := user.ExtractOrgID(ctx)
 	if err != nil {
 		return err

pkg/ingester/instance.go

@@ -531,4 +531,4 @@ func shouldConsiderStream(stream *stream, req *logproto.SeriesRequest) bool {
 		return true
 	}
 	return false
-}
+}

pkg/ingester/transfer.go

@@ -244,7 +244,7 @@ func (i *Ingester) transferOut(ctx context.Context) error {
 					return err
 				}
 
-				chunks := make([]*logproto.Chunk, 1, 1)
+				chunks := make([]*logproto.Chunk, 1)
 				chunks[0] = &logproto.Chunk{
 					Data: bb,
 				}

pkg/logcli/output/default_test.go

@@ -83,9 +83,8 @@ func TestDefaultOutput_Format(t *testing.T) {
 
 		t.Run(testName, func(t *testing.T) {
 			t.Parallel()
-
 			writer := &bytes.Buffer{}
-			out := &DefaultOutput{writer,testData.options}
+			out := &DefaultOutput{writer, testData.options}
 			out.FormatAndPrintln(testData.timestamp, testData.lbls, testData.maxLabelsLen, testData.line)
 
 			assert.Equal(t, testData.expected, writer.String())
@@ -114,7 +113,7 @@ func TestDefaultOutput_FormatLabelsPadding(t *testing.T) {
 	maxLabelsLen := findMaxLabelsLength(labelsList)
 	options := &LogOutputOptions{Timezone: time.UTC, NoLabels: false}
 	writer := &bytes.Buffer{}
-	out := &DefaultOutput{writer,options}
+	out := &DefaultOutput{writer, options}
 
 	// Format the same log line with different labels
 	formattedEntries := make([]string, 0, len(labelsList))

pkg/logcli/output/jsonl_test.go

@@ -68,7 +68,7 @@ func TestJSONLOutput_Format(t *testing.T) {
 		t.Run(testName, func(t *testing.T) {
 			t.Parallel()
 			writer := &bytes.Buffer{}
-			out := &JSONLOutput{writer,testData.options}
+			out := &JSONLOutput{writer, testData.options}
 			out.FormatAndPrintln(testData.timestamp, testData.lbls, testData.maxLabelsLen, testData.line)
 
 			actual := writer.String()

pkg/logcli/output/output.go

@@ -67,7 +67,7 @@ func NewLogOutput(w io.Writer, mode string, options *LogOutputOptions) (LogOutpu
 
 func getColor(labels string) *color.Color {
 	hash := fnv.New32()
-	hash.Write([]byte(labels))
+	_, _ = hash.Write([]byte(labels))
 	id := hash.Sum32() % uint32(len(colorList))
 	color := colorList[id]
 	return color

pkg/logcli/output/output_test.go

@@ -10,19 +10,19 @@ import (
 func TestNewLogOutput(t *testing.T) {
 	options := &LogOutputOptions{time.UTC, false, false}
 
-	out, err := NewLogOutput(nil,"default", options)
+	out, err := NewLogOutput(nil, "default", options)
 	assert.NoError(t, err)
-	assert.IsType(t, &DefaultOutput{nil,options}, out)
+	assert.IsType(t, &DefaultOutput{nil, options}, out)
 
-	out, err = NewLogOutput(nil,"jsonl", options)
+	out, err = NewLogOutput(nil, "jsonl", options)
 	assert.NoError(t, err)
-	assert.IsType(t, &JSONLOutput{nil,options}, out)
+	assert.IsType(t, &JSONLOutput{nil, options}, out)
 
-	out, err = NewLogOutput(nil,"raw", options)
+	out, err = NewLogOutput(nil, "raw", options)
 	assert.NoError(t, err)
-	assert.IsType(t, &RawOutput{nil,options}, out)
+	assert.IsType(t, &RawOutput{nil, options}, out)
 
-	out, err = NewLogOutput(nil,"unknown", options)
+	out, err = NewLogOutput(nil, "unknown", options)
 	assert.Error(t, err)
 	assert.Nil(t, out)
 }

pkg/logcli/output/raw.go

@@ -14,9 +14,9 @@ type RawOutput struct {
 	options *LogOutputOptions
 }
 
-func NewRaw (writer io.Writer, options *LogOutputOptions) LogOutput {
+func NewRaw(writer io.Writer, options *LogOutputOptions) LogOutput {
 	return &RawOutput{
-		w: writer,
+		w:       writer,
 		options: options,
 	}
 }

pkg/logcli/output/raw_test.go

@@ -67,7 +67,7 @@ func TestRawOutput_Format(t *testing.T) {
 			t.Parallel()
 
 			writer := &bytes.Buffer{}
-			out := &RawOutput{writer,testData.options}
+			out := &RawOutput{writer, testData.options}
 			out.FormatAndPrintln(testData.timestamp, testData.lbls, testData.maxLabelsLen, testData.line)
 
 			assert.Equal(t, testData.expected, writer.String())

pkg/logcli/query/query.go

@@ -84,7 +84,7 @@ func (q *Query) DoQuery(c client.Client, out output.LogOutput, statistics bool)
 		if q.Limit < q.BatchSize {
 			q.BatchSize = q.Limit
 		}
-		resultLength := q.BatchSize
+		resultLength := 0
 		total := 0
 		start := q.Start
 		end := q.End
@@ -114,7 +114,7 @@ func (q *Query) DoQuery(c client.Client, out output.LogOutput, statistics bool)
 				break
 			}
 			// Also no result, wouldn't expect to hit this.
-			if lastEntry == nil || len(lastEntry) == 0 {
+			if len(lastEntry) == 0 {
 				break
 			}
 			// Can only happen if all the results return in one request
@@ -321,7 +321,7 @@ func (q *Query) printStream(streams loghttp.Streams, out output.LogOutput, lastE
 	printed := 0
 	for _, e := range allEntries {
 		// Skip the last entry if it overlaps, this happens because batching includes the last entry from the last batch
-		if lastEntry != nil && len(lastEntry) > 0 && e.entry.Timestamp == lastEntry[0].Timestamp {
+		if len(lastEntry) > 0 && e.entry.Timestamp == lastEntry[0].Timestamp {
 			skip := false
 			// Because many logs can share a timestamp in the unlucky event a batch ends with a timestamp
 			// shared by multiple entries we have to check all that were stored to see if we've already