Fix Pod log annotation and label assignment #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petewall
requested review from
skl,
nevermind89x,
jewbetcha and
sleepyfoodie
Signed-off-by: Pete Wall <[email protected]>
petewall
force-pushed
the
fix/pod-log-annotations-and-labels
branch
from
b62bf57 to
6b09da9
Compare
skl
approved these changes
Feb 10, 2025
|
Thanks for the quick fix! 🙂 |
bentonam
pushed a commit
that referenced
this pull request
Feb 11, 2025
Signed-off-by: Pete Wall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, it was using the implicit
(.*)regex, which means it would unset labels if the annotation was not defined.Because we have
k8s.grafana.com/logs.job==>job, it means we always removed the job label.Added an integration test to validate the change (it reproduced the failure initially)