set service_name label for podLogs #1175
Open
+2,660
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petewall
approved these changes
Jan 28, 2025
petewall
approved these changes
Jan 28, 2025
rlankfo
changed the title
rlankfo
changed the title
bentonam
reviewed
Jan 29, 2025
charts/k8s-monitoring/charts/feature-pod-logs/templates/_common_pod_discovery.alloy.tpl
Outdated
Show resolved
Hide resolved
rlankfo
commented
Jan 29, 2025
rlankfo
force-pushed
the
rlankfo/otlp-gateway-logs-service-name
branch
from
2f134cb to
6dc7369
Compare
rlankfo
force-pushed
the
rlankfo/otlp-gateway-logs-service-name
branch
3 times, most recently
from
de5ea21 to
f248799
Compare
rlankfo
commented
Jan 30, 2025
Comment on lines
+64
to
+84
| // explicitly set service_name. if not set, loki will automatically try to populate a default. | ||
| // see https://grafana.com/docs/loki/latest/get-started/labels/#default-labels-for-all-users | ||
| // | ||
| // choose the first value found from the following ordered list: | ||
| // - pod.annotation[resource.opentelemetry.io/service.name] | ||
| // - pod.label[app.kubernetes.io/name] | ||
| // - k8s.pod.name | ||
| // - k8s.container.name | ||
| rule { | ||
| action = "replace" | ||
| source_labels = [ | ||
| "__meta_kubernetes_pod_annotation_resource_opentelemetry_io_service_name", | ||
| "__meta_kubernetes_pod_label_app_kubernetes_io_name", | ||
| "__meta_kubernetes_pod_name", | ||
| "__meta_kubernetes_pod_container_name", | ||
| ] | ||
| separator = ";" | ||
| regex = "^(?:;*)?([^;]+).*$" | ||
| replacement = "$1" | ||
| target_label = "service_name" | ||
| } |
There was a problem hiding this comment.
@cyrille-leclerc do you mind taking a look at this?
I can't include other values used by the opentelemetry operator (statefulset, deployment, etc.) because they are not currently supported by prometheus kubernetes service discovery.
rlankfo
changed the title
Signed-off-by: Robbie Lankford <[email protected]>
rlankfo
force-pushed
the
rlankfo/otlp-gateway-logs-service-name
branch
from
f248799 to
310a260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
service_name,service_namespace,deployment_environment, anddeployment_environment_namelabels on Loki pod logs. This works when sent to loki destinations. I'll follow this PR up with updates for pod logs sent to OTLP destinations.The labels are set according to the following rules:
service_namelabel set by taking the first non-empty value from these Kubernetes metadata fields (in order): the pod annotationresource.opentelemetry.io/service.name, the pod labelapp.kubernetes.io/name, the pod’s name, or the container’s name.service_namespaceset byresource.opentelemetry.io/service.namespacepod annotation.deployment_environmentset byresource.opentelemetry.io/deployment.environmentpod annotation.deployment_environment_nameset byresource.opentelemetry.io/deployment.environment.namepod annotation.If not set, Loki will attempt to set a default value according to these rules: https://grafana.com/docs/loki/latest/get-started/labels/#default-labels-for-all-users