Fix handling of GET form submissions in submitForm() #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 62.81% 62.89% +0.08%
==========================================
Files 90 90
Lines 6370 6376 +6
==========================================
+ Hits 4001 4010 +9
+ Misses 2146 2145 -1
+ Partials 223 221 -2
Continue to review full report at Codecov.
|
|
Nice! We need the logic and the test anyway. When #436 is done the implementation of this can just be a bit simplified. |
|
Yup, true. I'll merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marklagendijk Here's a quick fix for handling GET form submissions, until we have #436.