Unit tests for config file operations #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
requested review from
mstoykov and
inancgumus
and removed request for
a team
codebien
force-pushed
the
config-file-tests
branch
from
a9e3047 to
4fe44f4
Compare
inancgumus
previously approved these changes
Jan 30, 2025
Co-authored-by: İnanç Gümüş <[email protected]>
@inancgumus my feeling is that there are differences between tests that will make readability worst if we are going to do that as table tests. I can do a refactor attempt in a dedicated pull request, but I'll look into it after we merged #4301 👍 |
codebien
requested review from
a team,
mstoykov,
inancgumus and
oleiade
and removed request for
mstoykov and
a team
mstoykov
approved these changes
Jan 31, 2025
oleiade
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It adds a series of unit tests to cover operations on the config file on disk storage.
Why?
It creates a safer context for applying changes for #2508