Rename browser data directory #4293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ankur22
approved these changes
Jan 28, 2025
inancgumus
requested review from
codebien and
joanlopez
and removed request for
a team
codebien
approved these changes
Jan 29, 2025
joanlopez
approved these changes
Jan 29, 2025
We export it so that we won't need to change it in multiple places when we want to rename it again.
inancgumus
force-pushed
the
rename/browser-data-directory
branch
from
4ad7e03 to
2fa7028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Renames
xk6-browser-data-*tok6browser-data-*.Why?
k6browser-artifacts-*xk6-browsername.Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)